Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect helm-buffer-max-length if it's nil #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samertm
Copy link

@samertm samertm commented Nov 11, 2022

Don't overwrite helm-buffer-max-length when it's nil, because nil indicates that we should use the max length of the longest file every time.

This code is now the same as what helm-buffers does: https://github.com/emacs-helm/helm/blob/8ed0ab7762ad76da02d8832aa18d03e1288ea6d5/helm-buffers.el#L300

You can reproduce the issue by setting helm-buffer-max-length to nil, opening helm projectile, and then opening helm buffer and seeing that the files in the buffer may be getting cut off if the longest file in helm projectile is shorter.

This is just a drive-by PR and I've fixed the problem on my end, so I haven't checked the boxes below. If it's too much extra work on your end, no need to merge. Thanks!!


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

Don't overwrite helm-buffer-max-length when it's nil, because nil
indicates that we should use the max length of the longest file every
time.

This code is now the same as what helm-buffers does:
https://github.com/emacs-helm/helm/blob/8ed0ab7762ad76da02d8832aa18d03e1288ea6d5/helm-buffers.el#L300
@bbatsov
Copy link
Owner

bbatsov commented Oct 12, 2023

The changes look good, but your branch has to be rebased on top of the current master branch due to merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants